Display line numbers Function #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems a legacy of Egypt, which used GCC as extractor
The Graph::Writer::Dot is on the CPAN and it is a mature piece of software, it do almost the same job of the Analizo::Output::DOT, then in my opinion is much better to use the Graph::Writer::Dot instead of maintain the same code in the Analizo side. But Graph::Writer::Dot doesn't have a important feature implemented in the Analizo::Output::DOT to cluster the graph in subgraphs. That way I implemented this feature in Graph::Writer::Dot and sent it to the upstream author. While the upstream author doesn't review my code I'm adding here (in the Analizo side) the file "lib/Graph/Writer/Dot.pm" that implements the Graph::Writer::Dot.
In the acceptance tests * New build dependencies: - Test::BDD::Cucumber - Method::Signatures - File::Slurp * Acceptance tests are going to the directory 't/features' (http://analizo.org/Development/ActionItem17)
* New dependency: File::Copy::Recursive * Porting analizo_steps.rb (Ruby) to analizo_steps.pl (Perl)
* graph/help.feature * graph/input-files.feature * graph/omit.feature
To execute Before{} and After{} blocks
For now, I've just made a workaround to provide a way to execute code
after every scenario...
* graph/cluster.feature * graph/modules.feature * graph/plain.feature
graph/output-file.feature language_support.feature module_file_mapping.feature
Instead of T::B::C::TermColor also, lots of acceptance tests migrated from Ruby to Perl
Also, dsm.feature migrated
- metrics_history.feature - metrics_history_db.feature - tree_evolution.feature
… of test.pl $ perl test.pl t/features/dsm.feature
Identified rcopy() bug. Fixing related tests. Signed-off-by: Alexandre Barbosa <[email protected]> Signed-off-by: Lucas Kanashiro <[email protected]>
Conflicts: lib/Analizo/Output/DOT.pm t/Analizo/Output/DOT.t
Signed-off-by: Paulo Borba <[email protected]> Signed-off-by: Alysson Raniere <[email protected]>
Signed-off-by: Alysson Raniere <[email protected]> Signed-off-by: Carlos Filipe <[email protected]> Signed-off-by: Paulo Borba <[email protected]> Signed-off-by: Charles Oliveira <[email protected]>
Signed-off-by: Lucas Kanashiro <[email protected]> Signed-off-by: Alexandre Barbosa <[email protected]>
DNS change will come when we are sure about the change.
Fixing Test file name and test method Signed-off-by: Alexandre Barbosa <[email protected]> Signed-off-by: Lucas Kanashiro <[email protected]>
Signed-off-by: Alexandre Barbosa <[email protected]> Signed-off-by: Lucas Kanashiro <[email protected]>
Signed-off-by: Alexandre Barbosa <[email protected]> Signed-off-by: Lucas Kanashiro <[email protected]>
Removed Analizo's Dot.pm and added dependency Graph:Writer:Dot Signed-off-by: Alexandre Barbosa <[email protected]> Signed-off-by: Lucas Kanashiro <[email protected]>
Enabling checkers for improve static security anallysis Signed-off-by: Alexandre Barbosa <[email protected]> Signed-off-by: Lucas Kanashiro <[email protected]>
|
Guys, you must follow only one programming pattern. For example, you do this: (it is OK in Analizo) And this: (Not OK) And another question, your merge request must have only commits relation with some issue, in this case, display line numbers. I cannot review your code because have a lot of commits and you modified some files that it is not necessary. Besides having commented code. Please, try to review this questions. |
Creation of function that allows you to see where the secutiry metrics occurs. Structure of the tree was modified in the process to include the line where the security metric occurs. Tests all green. Signed-off-by: Alysson Raniere <[email protected]> Signed-off-by: Carlos Filipe <[email protected]> Signed-off-by: Paulo Borba <[email protected]> Signed-off-by: Charles Oliveira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests are running ok, all green. The function Display Line Numbers is working fine, requesting pull...